Rename Phase4 -> Compat, make it default

Summary:
This changes the name and the default value typegen phase.

The new name is `Compat` - as it exports both new (correct types) and "old" types for operations:

```
export type InternAppQueryVariables = InternAppQuery$variables;
export type InternAppQuery$data = {|
  +node: ?{|
    +$fragmentSpreads: Component_user1$fragmentType & CommonComponent_fragment$fragmentType & PageComponent_user$fragmentType,
  |},
|};
export type InternAppQueryResponse = InternAppQuery$data;
export type InternAppQuery = {|
  variables: InternAppQueryVariables,
  response: InternAppQuery$data,
|};
*/
```

See `InternAppQueryVariables`  and `InternAppQuery`.

This should reduce some issues when updating to V13. See: #3679

Reviewed By: kassens

Differential Revision: D33338628

fbshipit-source-id: 31a22c7c14ff28fcb9236fef83d1bbd51fa65c86

compiler/crates/relay-config/src/typegen_config.rs

@@ -100,7 +100,7 @@ impl Default for FlowTypegenConfig {
     fn default() -> Self {
         Self {
             no_future_proof_enums: false,
-            phase: FlowTypegenPhase::Final,
+            phase: FlowTypegenPhase::Compat,
             rollout: Rollout::default(),
         }
     }
@@ -120,11 +120,12 @@ impl FlowTypegenConfig {
 
 #[derive(Debug, Serialize, Deserialize, Clone, Copy, PartialEq, Eq)]
 pub enum FlowTypegenPhase {
-    /// - remove $fragmentRefs for spreads
-    /// - remove $refType from Frag$data
-    Phase4,
     /// Final state
     Final,
+    /// - remove $fragmentRefs for spreads
+    /// - remove $refType from Frag$data
+    /// - keep exporting old types for operations
+    Compat,
 }
 
 impl FlowTypegenPhase {
@@ -133,8 +134,8 @@ impl FlowTypegenPhase {
     fn previous(self) -> Self {
         use FlowTypegenPhase::*;
         match self {
-            Phase4 => Phase4,
-            Final => Phase4,
+            Final => Compat,
+            Compat => Compat,
         }
     }
 }

compiler/crates/relay-typegen/src/flow.rs

@@ -89,7 +89,7 @@ impl Writer for FlowPrinter {
 
     fn write_export_fragment_type(&mut self, old_name: &str, new_name: &str) -> FmtResult {
         match self.flow_typegen_phase {
-            FlowTypegenPhase::Phase4 => {
+            FlowTypegenPhase::Compat => {
                 writeln!(
                     &mut self.result,
                     "declare export opaque type {new_name}: FragmentType;

compiler/crates/relay-typegen/src/lib.rs

@@ -252,7 +252,7 @@ impl<'a> TypeGenerator<'a> {
         self.write_input_object_types()?;
 
         match self.flow_typegen_phase {
-            FlowTypegenPhase::Phase4 => {
+            FlowTypegenPhase::Compat => {
                 let new_variables_identifier = format!("{}$variables", typegen_operation.name.item);
                 self.writer
                     .write_export_type(&new_variables_identifier, &input_variables_type)?;
@@ -269,7 +269,7 @@ impl<'a> TypeGenerator<'a> {
         }
 
         let response_identifier = match self.flow_typegen_phase {
-            FlowTypegenPhase::Phase4 => {
+            FlowTypegenPhase::Compat => {
                 let new_response_identifier = format!("{}$data", typegen_operation.name.item);
                 let old_response_identifier = format!("{}Response", typegen_operation.name.item);
                 self.writer
@@ -289,7 +289,7 @@ impl<'a> TypeGenerator<'a> {
         };
 
         match self.flow_typegen_phase {
-            FlowTypegenPhase::Phase4 => {
+            FlowTypegenPhase::Compat => {
                 let mut operation_types = vec![
                     Prop::KeyValuePair(KeyValuePairProp {
                         key: *VARIABLES,
@@ -494,7 +494,7 @@ impl<'a> TypeGenerator<'a> {
         }
 
         match self.flow_typegen_phase {
-            FlowTypegenPhase::Phase4 => {
+            FlowTypegenPhase::Compat => {
                 self.writer.write_export_type(&data_type_name, &type_)?;
                 self.writer.write_export_type(
                     data_type.lookup(),

compiler/crates/relay-typegen/tests/generate_flow/mod.rs

@@ -13,10 +13,10 @@ use graphql_syntax::parse_executable;
 use indexmap::IndexMap;
 use intern::string_key::Intern;
 use relay_codegen::JsModuleFormat;
-use relay_config::ProjectConfig;
+use relay_config::{FlowTypegenConfig, ProjectConfig};
 use relay_test_schema::{get_test_schema, get_test_schema_with_extensions};
 use relay_transforms::apply_transforms;
-use relay_typegen::{self, TypegenConfig, TypegenLanguage};
+use relay_typegen::{self, FlowTypegenPhase, TypegenConfig, TypegenLanguage};
 use std::sync::Arc;
 
 type FnvIndexMap<K, V> = IndexMap<K, V, FnvBuildHasher>;
@@ -70,6 +70,10 @@ pub fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
     let typegen_config = TypegenConfig {
         language: TypegenLanguage::Flow,
         custom_scalar_types,
+        flow_typegen: FlowTypegenConfig {
+            phase: FlowTypegenPhase::Final,
+            ..Default::default()
+        },
         ..Default::default()
     };
 

compiler/crates/relay-typegen/tests/generate_typescript/mod.rs

@@ -12,10 +12,10 @@ use graphql_ir::{build, Program};
 use graphql_syntax::parse_executable;
 use intern::string_key::Intern;
 use relay_codegen::JsModuleFormat;
-use relay_config::ProjectConfig;
+use relay_config::{FlowTypegenConfig, ProjectConfig};
 use relay_test_schema::{get_test_schema, get_test_schema_with_extensions};
 use relay_transforms::apply_transforms;
-use relay_typegen::{self, TypegenConfig, TypegenLanguage};
+use relay_typegen::{self, FlowTypegenPhase, TypegenConfig, TypegenLanguage};
 use std::sync::Arc;
 
 pub fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
@@ -54,6 +54,10 @@ pub fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
     let has_unified_output = false;
     let typegen_config = TypegenConfig {
         language: TypegenLanguage::TypeScript,
+        flow_typegen: FlowTypegenConfig {
+            phase: FlowTypegenPhase::Final,
+            ..Default::default()
+        },
         ..Default::default()
     };