-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reuse TypegenConfig for SingleProjectConfigFile (#4585)
Summary: There are some slight discrepancies between multi- and single-project configs at the moment, with some options only being configurable from multi-project configs, even though the compiler could read and support the same settings from both type of configs (examples: `use_import_type_syntax`, `require_custom_scalar_types`, etc.). ## Changes - Flatten `TypegenConfig` in `SingleProjectConfigFile` and remove duplicated options - Inlines `no_future_proof_enums` from `FlowTypegenConfig` into `TypegenConfig` and removes `FlowTypegenConfig` as it's now no longer required - When parsing of the config file fails, show the single-project config error first, since that is the configuration most people use ##⚠️ Breaking change This change is a breaking change, as the `custom_scalars` config option in the single-project config must now be specified as `custom_scalar_types`. Pull Request resolved: #4585 Test Plan: captbaritone: I've confirmed that WWW still compiles without error I validated that omitting `language` still results in an error (it is now consistent and both single or multi project configs require the `language` field. {F1318391525} Reviewed By: alunyov Differential Revision: D52806277 Pulled By: captbaritone fbshipit-source-id: 02d889833a1d0979c28037cf48b5ae9fa129448d
- Loading branch information
1 parent
5718ca9
commit 4e68155
Showing
5 changed files
with
27 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters