Skip to content

Commit

Permalink
Remove unused method arguments (#4326)
Browse files Browse the repository at this point in the history
Summary:
Looks like `parent` is not used in these methods anymore. Nor was `record` used by `_validateConflictingLinkedFieldsWithIdenticalId`.

Pull Request resolved: #4326

Reviewed By: voideanvalue

Differential Revision:
D46361012

Privacy Context Container: L1125407

Pulled By: captbaritone

fbshipit-source-id: 51bc21bcfff9e499fac6270c408c011bb120fefa
  • Loading branch information
captbaritone authored and facebook-github-bot committed Jun 8, 2023
1 parent af8a619 commit 59912af
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions packages/relay-runtime/store/RelayResponseNormalizer.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class RelayResponseNormalizer {
switch (selection.kind) {
case SCALAR_FIELD:
case LINKED_FIELD:
this._normalizeField(node, selection, record, data);
this._normalizeField(selection, record, data);
break;
case CONDITION:
const conditionValue = Boolean(
Expand Down Expand Up @@ -301,7 +301,7 @@ class RelayResponseNormalizer {
});
break;
case MODULE_IMPORT:
this._normalizeModuleImport(node, selection, record, data);
this._normalizeModuleImport(selection, record, data);
break;
case DEFER:
this._normalizeDefer(selection, record, data);
Expand All @@ -322,7 +322,7 @@ class RelayResponseNormalizer {
this._traverseSelections(selection.fragment, record, data);
break;
case ACTOR_CHANGE:
this._normalizeActorChange(node, selection, record, data);
this._normalizeActorChange(selection, record, data);
break;
case RELAY_RESOLVER:
this._normalizeResolver(selection, record, data);
Expand Down Expand Up @@ -422,7 +422,6 @@ class RelayResponseNormalizer {
}

_normalizeModuleImport(
parent: NormalizationNode,
moduleImport: NormalizationModuleImport,
record: Record,
data: PayloadData,
Expand Down Expand Up @@ -464,7 +463,6 @@ class RelayResponseNormalizer {
}

_normalizeField(
parent: NormalizationNode,
selection: NormalizationLinkedField | NormalizationScalarField,
record: Record,
data: PayloadData,
Expand Down Expand Up @@ -556,7 +554,6 @@ class RelayResponseNormalizer {
}

_normalizeActorChange(
parent: NormalizationNode,
selection: NormalizationActorChange,
record: Record,
data: PayloadData,
Expand Down Expand Up @@ -676,7 +673,6 @@ class RelayResponseNormalizer {
);
if (__DEV__) {
this._validateConflictingLinkedFieldsWithIdenticalId(
record,
RelayModernRecord.getLinkedRecordID(record, storageKey),
nextID,
storageKey,
Expand Down Expand Up @@ -758,7 +754,6 @@ class RelayResponseNormalizer {
if (__DEV__) {
if (prevIDs) {
this._validateConflictingLinkedFieldsWithIdenticalId(
record,
prevIDs[nextIndex],
nextID,
storageKey,
Expand Down Expand Up @@ -828,7 +823,6 @@ class RelayResponseNormalizer {
* Warns if a single response contains conflicting fields with the same id
*/
_validateConflictingLinkedFieldsWithIdenticalId(
record: Record,
prevID: ?DataID,
nextID: DataID,
storageKey: string,
Expand Down

0 comments on commit 59912af

Please sign in to comment.