-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Regression test for not detecting undefined variables on resolver fields
Reviewed By: alunyov Differential Revision: D50251703 fbshipit-source-id: ed1ecf58dbfbb89a74b98d6eaf612a00765b7832
- Loading branch information
1 parent
2699206
commit 998fd49
Showing
5 changed files
with
289 additions
and
1 deletion.
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
...e_relay_artifacts/fixtures/client-fields-with-undefined-global-variables.invalid.expected
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| ==================================== INPUT ==================================== | ||
| # expected-to-throw | ||
|
|
||
| query clientFieldsWithUndefinedGlobalVariablesQuery($id: ID!) { | ||
| node(id: $id) { | ||
| ...clientFieldsWithUndefinedGlobalVariables_user | ||
| } | ||
| } | ||
|
|
||
| fragment clientFieldsWithUndefinedGlobalVariables_user on User { | ||
| pop_star_name(scale: $scale) | ||
| } | ||
|
|
||
| # %extensions% | ||
|
|
||
| extend type User { | ||
| pop_star_name(scale: Float!): String | ||
| } | ||
| ==================================== ERROR ==================================== | ||
| ✖︎ Operation 'clientFieldsWithUndefinedGlobalVariablesQuery' references undefined variable: '$scale'. | ||
|
|
||
| client-fields-with-undefined-global-variables.invalid.graphql:10:24 | ||
| 9 │ fragment clientFieldsWithUndefinedGlobalVariables_user on User { | ||
| 10 │ pop_star_name(scale: $scale) | ||
| │ ^^^^^^ | ||
| 11 │ } |
17 changes: 17 additions & 0 deletions
17
...le_relay_artifacts/fixtures/client-fields-with-undefined-global-variables.invalid.graphql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # expected-to-throw | ||
|
|
||
| query clientFieldsWithUndefinedGlobalVariablesQuery($id: ID!) { | ||
| node(id: $id) { | ||
| ...clientFieldsWithUndefinedGlobalVariables_user | ||
| } | ||
| } | ||
|
|
||
| fragment clientFieldsWithUndefinedGlobalVariables_user on User { | ||
| pop_star_name(scale: $scale) | ||
| } | ||
|
|
||
| # %extensions% | ||
|
|
||
| extend type User { | ||
| pop_star_name(scale: Float!): String | ||
| } |
210 changes: 210 additions & 0 deletions
210
..._relay_artifacts/fixtures/relay-resolver-with-undefined-global-variables.invalid.expected
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,210 @@ | ||
| ==================================== INPUT ==================================== | ||
| # TODO: expected to throw | ||
|
|
||
| query relayResolverWithUndefinedGlobalVariablesQuery { | ||
| node(id: "SOME_ID") { | ||
| ...relayResolverWithUndefinedGlobalVariables_PopStarName | ||
| } | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarName on User { | ||
| pop_star_name(scale: $scale) | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name on User { | ||
| name | ||
| } | ||
|
|
||
| # %extensions% | ||
|
|
||
| extend type User { | ||
| pop_star_name(scale: Float!): String @relay_resolver(fragment_name: "relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name", import_path: "./path/to/PopStarNameResolver.js") | ||
| } | ||
| ==================================== OUTPUT =================================== | ||
| { | ||
| "fragment": { | ||
| "argumentDefinitions": [], | ||
| "kind": "Fragment", | ||
| "metadata": null, | ||
| "name": "relayResolverWithUndefinedGlobalVariablesQuery", | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": [ | ||
| { | ||
| "kind": "Literal", | ||
| "name": "id", | ||
| "value": "SOME_ID" | ||
| } | ||
| ], | ||
| "concreteType": null, | ||
| "kind": "LinkedField", | ||
| "name": "node", | ||
| "plural": false, | ||
| "selections": [ | ||
| { | ||
| "args": null, | ||
| "kind": "FragmentSpread", | ||
| "name": "relayResolverWithUndefinedGlobalVariables_PopStarName" | ||
| } | ||
| ], | ||
| "storageKey": "node(id:\"SOME_ID\")" | ||
| } | ||
| ], | ||
| "type": "Query", | ||
| "abstractKey": null | ||
| }, | ||
| "kind": "Request", | ||
| "operation": { | ||
| "argumentDefinitions": [], | ||
| "kind": "Operation", | ||
| "name": "relayResolverWithUndefinedGlobalVariablesQuery", | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": [ | ||
| { | ||
| "kind": "Literal", | ||
| "name": "id", | ||
| "value": "SOME_ID" | ||
| } | ||
| ], | ||
| "concreteType": null, | ||
| "kind": "LinkedField", | ||
| "name": "node", | ||
| "plural": false, | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": null, | ||
| "kind": "ScalarField", | ||
| "name": "__typename", | ||
| "storageKey": null | ||
| }, | ||
| { | ||
| "kind": "InlineFragment", | ||
| "selections": [ | ||
| { | ||
| "name": "pop_star_name", | ||
| "args": [ | ||
| { | ||
| "kind": "Variable", | ||
| "name": "scale", | ||
| "variableName": "scale" | ||
| } | ||
| ], | ||
| "fragment": { | ||
| "kind": "InlineFragment", | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": null, | ||
| "kind": "ScalarField", | ||
| "name": "name", | ||
| "storageKey": null | ||
| } | ||
| ], | ||
| "type": "User", | ||
| "abstractKey": null | ||
| }, | ||
| "kind": "RelayResolver", | ||
| "storageKey": null, | ||
| "isOutputType": false | ||
| } | ||
| ], | ||
| "type": "User", | ||
| "abstractKey": null | ||
| }, | ||
| { | ||
| "alias": null, | ||
| "args": null, | ||
| "kind": "ScalarField", | ||
| "name": "id", | ||
| "storageKey": null | ||
| } | ||
| ], | ||
| "storageKey": "node(id:\"SOME_ID\")" | ||
| } | ||
| ] | ||
| }, | ||
| "params": { | ||
| "cacheID": "8c99a70a7ba2df2195b28ab9b19b84eb", | ||
| "id": null, | ||
| "metadata": {}, | ||
| "name": "relayResolverWithUndefinedGlobalVariablesQuery", | ||
| "operationKind": "query", | ||
| "text": null | ||
| } | ||
| } | ||
|
|
||
| QUERY: | ||
|
|
||
| query relayResolverWithUndefinedGlobalVariablesQuery { | ||
| node(id: "SOME_ID") { | ||
| __typename | ||
| ...relayResolverWithUndefinedGlobalVariables_PopStarName | ||
| id | ||
| } | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarName on User { | ||
| ...relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name on User { | ||
| name | ||
| } | ||
|
|
||
|
|
||
| { | ||
| "argumentDefinitions": [ | ||
| { | ||
| "kind": "RootArgument", | ||
| "name": "scale" | ||
| } | ||
| ], | ||
| "kind": "Fragment", | ||
| "metadata": null, | ||
| "name": "relayResolverWithUndefinedGlobalVariables_PopStarName", | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": [ | ||
| { | ||
| "kind": "Variable", | ||
| "name": "scale", | ||
| "variableName": "scale" | ||
| } | ||
| ], | ||
| "fragment": { | ||
| "args": null, | ||
| "kind": "FragmentSpread", | ||
| "name": "relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name" | ||
| }, | ||
| "kind": "RelayResolver", | ||
| "name": "pop_star_name", | ||
| "resolverModule": require('PopStarNameResolver'), | ||
| "path": "pop_star_name" | ||
| } | ||
| ], | ||
| "type": "User", | ||
| "abstractKey": null | ||
| } | ||
|
|
||
| { | ||
| "argumentDefinitions": [], | ||
| "kind": "Fragment", | ||
| "metadata": null, | ||
| "name": "relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name", | ||
| "selections": [ | ||
| { | ||
| "alias": null, | ||
| "args": null, | ||
| "kind": "ScalarField", | ||
| "name": "name", | ||
| "storageKey": null | ||
| } | ||
| ], | ||
| "type": "User", | ||
| "abstractKey": null | ||
| } |
21 changes: 21 additions & 0 deletions
21
...e_relay_artifacts/fixtures/relay-resolver-with-undefined-global-variables.invalid.graphql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # TODO: expected to throw | ||
|
|
||
| query relayResolverWithUndefinedGlobalVariablesQuery { | ||
| node(id: "SOME_ID") { | ||
| ...relayResolverWithUndefinedGlobalVariables_PopStarName | ||
| } | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarName on User { | ||
| pop_star_name(scale: $scale) | ||
| } | ||
|
|
||
| fragment relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name on User { | ||
| name | ||
| } | ||
|
|
||
| # %extensions% | ||
|
|
||
| extend type User { | ||
| pop_star_name(scale: Float!): String @relay_resolver(fragment_name: "relayResolverWithUndefinedGlobalVariables_PopStarNameResolverFragment_name", import_path: "./path/to/PopStarNameResolver.js") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters