Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RelayCompat from error messages #2663

Closed
wants to merge 2 commits into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Feb 26, 2019

This was only useful to improve the error message in case someone calls getFragment() on a RelayModern container which doesn't have this static method.

No runtime behavior actually changes by this as the method was throwing an error before and after.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kassens kassens changed the title Remove getFragment() stub from RelayModern container Remove RelayCompat from error messages Feb 26, 2019
@kassens kassens deleted the split-compat branch February 26, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants