Add MacOS ARM64 build target to relay-compiler for better M1 Mac support #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentriemer
changed the title
|
Thanks @vincentriemer! I think it's fine to add. The only concern I can think of is the size of the package itself. Because when we'll download this form NPM we will download all 4 files now. |
|
@alunyov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idk what the performance difference is since I don't have a project large enough where I can notice a difference but I figured there's no harm in at least providing an M1 native executable for the new relay-compiler.
Verified on my M1 MacBook Pro by manually downloading the new macOS-arm64 artifact built from the GH workflow and replacing a local executable which still runs successfully.