Create stand-alone PR to fix VSCode extension build #4275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captbaritone Here's the PR to just fix the build changes for the extension. |
|
Thank you! |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in 5dd6914. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 23, 2023
Summary: ernieturner originally had this line in #4275 but I thought it was safe to remove. Because the `vscode-extension` is now not part of the Yarn workspace, its ESLint dependencies do not get installed by default. This means linting those files will fail (since the TypeScript-specific ESLint packages are not installed). Here we add it back. The `vscode-extension` code gets linted with its own run. See https://github.com/facebook/relay/blob/7b5bee426ffc4fc5c9a3f9d06225020f7b7fe066/.github/workflows/ci.yml#L24 Pull Request resolved: #4322 Test Plan: See that this turns GitHub CI green again: https://github.com/facebook/relay/actions/runs/5050278394/jobs/9060793015?pr=4322 Reviewed By: josephsavona Differential Revision: D46085331 Pulled By: captbaritone fbshipit-source-id: 3c27c2a1db8ca94cf95ef70b5ba76b9ddb0721a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports over a subset of the changes from this PR that just fix some build issues with the VSCode extension. This works to build the extension locally, which should in theory also work with the Github Action publish step, but I can't fully verify that since it requires the marketplace PAT to run. However, we should not do a publish after this PR merges because the current tagged version is 2.0.0 and we should wait for the other PR to land before we publish, especially since we're not going to publish 2.0.0 and instead are planning on publishing version 1.3.0.