Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun relay compiler #4288

Closed
wants to merge 2 commits into from
Closed

Rerun relay compiler #4288

wants to merge 2 commits into from

Conversation

Anwesha-B
Copy link
Contributor

@Anwesha-B Anwesha-B commented Apr 20, 2023

The project comes with precompiled relay fragments that do not work when the student who is just starting this tutorial tries to fetch the top query without having any fragments defined. To make it work, we need to delete the precompiled queries and re compile. The student also does not know the command to do that since it is not mentioned anywhere and they may not know to look for it in the package.json file. These specifics are important to unblock the student at this stage.

The project comes with precompiled relay fragments that do not work when the student who is just starting this tutorial tries to fetch the top query without having ant fragments defined. To make it work, we need to delete the precompiled queries and re compile. The student also does not know the command to do that since it is not mentioned anywhere since they may not know to look for it in the `package.json` file. These specifics are important to unblock the student at this stage.
@facebook-github-bot
Copy link
Contributor

Hi @Anwesha-B!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@captbaritone merged this pull request in 97cedbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants