Create shared mock for scheduler #4313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Ignore mocks dir when testing dependencies Don't use __mocks__ Revert change to testDependencies tfoo
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
eoin
reviewed
May 12, 2023
Co-authored-by: Eoin Hennessy <eoin.hennessy@gmail.com>
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in cc1daa1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of scheduler we get internally is always the latest. However, on GitHub we get the version is a transitive dependency from
react-test-renderer.Some methods in the unstable_mock have been renamed between these two versions. This mock file provides a centralized place to reconcile those differences so that the same tests can work both internally and on GitHub.
I also tried manually upgrading
react-test-rendererto the@experimentaltag in the hopes of getting GitHub to use the same version we have internally, and then transitively inherit the more recent version ofscheduler. Unfortunately that created many test failures for reasons I don't currently fully understand.