Link to persisted queries in tutorial #4359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Looks like this also includes #4355. |
|
Ah, sorry! Will fix it 😊 |
|
So, there are more problems with tutorial later on. Should I create one bigger PR or several small ones? |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Multiple small PRs is generally better. |
|
Looks like GitHub is reporting merge conflicts. Would you mind rebasing? |
|
ping @robinpokorny waiting on rebase |
robinpokorny
force-pushed
the
Link-to-persisted-queries-in-tutorial
branch
from
367789e
to
ca1a72b
Compare
robinpokorny
force-pushed
the
Link-to-persisted-queries-in-tutorial
branch
from
ca1a72b
to
96ae953
Compare
|
Fixed :) |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in 007eff0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct name and add link to Persisted queries