Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay-compiler] Export node from assignable fragment #4409

Conversation

tobias-tengler
Copy link
Contributor

@tobias-tengler tobias-tengler commented Aug 11, 2023

Required for #4370

@facebook-github-bot
Copy link
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tobias-tengler
Copy link
Contributor Author

@captbaritone I think I'm not supposed to check in the cargo.lock file, but it needs to be updated for the tests to run. Should I create a separate PR to update the lockfile?

@captbaritone
Copy link
Contributor

Fix is here (I just imported it): #4402 you can ignore those test failures, they'll run correctly internally

@tobias-tengler
Copy link
Contributor Author

tobias-tengler commented Aug 18, 2023

@captbaritone I updated all my PRs with the recently merged Cargo.lock update and all the tests are passing again 🎉

🤞we can get this PR and the others merged soon:
#4370
#4380
#4404

@facebook-github-bot
Copy link
Contributor

@captbaritone merged this pull request in 1328fc1.

@tobias-tengler tobias-tengler deleted the export-node-from-assignable-fragment branch August 21, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants