React Native Compatibility #713
Conversation
|
Awesome, thanks for working on this! |
|
💯 |
|
👍 👏 |
| @@ -0,0 +1,19 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can this file be named RelayUnstableBatchedUpdates.native.js?
There was a problem hiding this comment.
Indeed it can, and we can get rid of what's in package.json...because the RN packager looks for the native extension. Though @spicyj has mentioned that he'd like to remove that eventually. I suppose if he does, we can just put back the package.json directive.
|
This is great — thanks for tackling it. And great write ups, too. |
Use the proper unstable_batchedupdates for each platform
|
Do you suppose there's any chance to pull this |
|
@skevy this is now blocked only on facebook/react-native#5084, right? |
|
@josephsavona yah. Hopefully being merged soon! :) |
|
Fyi @josephsavona, fbjs 0.7.0 is now released, so presuming you don't have any changes on this PR, it can be merged :) |
|
Would also be cool if you could release relay@0.6.2 -- nothing in here is breaking, so it should keep in line with semver. |
|
@facebook-github-bot import |
| @@ -85,6 +85,7 @@ | |||
| "<rootDir>/src/" | |||
| ], | |||
| "unmockedModulePathPatterns": [ | |||
| "<rootDir>/src/tools/RelayUnstableBatchedUpdates.js", | |||
There was a problem hiding this comment.
i'm assuming a manual mock with module.exports = require.requireActual('...') won't work?
There was a problem hiding this comment.
Honestly, I'm not sure how to do that :( Sorry...not a Jest expert. If you point me in the right direction, happy to make the change...otherwise I defer to your decision on that.
Based on my limited knowledge of requireActual...it seems like it would work fine. But I'm not 100% certain.
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1014651835240270/int_phab to review. |
ghost
closed this
in
This PR depends on an unreleased version of
fbjs, so DO NOT MERGE.When merged along with facebook/react-native#5084, facebook/fbjs#95, and whatever PR fixes facebook/react-native#4062 (which I will update this issue with when I push it), this fixes #26.
The changes to Relay itself are super minor here:
unstable_batchedupdates. So to fix, I abstracted the reference tounstable_batchedupdatesto it's own module, and then took advantage of the "react-native"package.jsonoption, supported by the React Native packager, to load the correct version of this function given the execution context.react-domfrom peerDependencies (but kept it in devDependencies, for use in tests), and also upgrade thefbjsdependency to a (yet unreleased) version that provides better compatibility with React Native.