Add option to CMake for building static libraries #12890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Bindu-Bhabu, thank you for you PR. I tested your PR locally and it break our Java builds. I need to add extra parameter
Radek |
|
@rhubner , default is updated, Kindly check |
ROCKSDB creates a STATIC library target reference by default. Modify the cmake so that the STATIC library is also an option just like creating a SHARED library but kept OFF by default.
Update Static library option default to ON.
|
LGTM ✅ |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 9, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabu@kpit.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 9, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabu@kpit.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 9, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabu@kpit.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 9, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabu@kpit.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Aug 10, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabu@kpit.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Aug 11, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabukpit.com> Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Aug 18, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabukpit.com> Signed-off-by: Khem Raj <raj.khemgmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Aug 19, 2024
Modify the CMakeLists.txt to add an Option for STATIC target import, as available for shared library. Link: facebook/rocksdb#12890 Configure static library default to switched off as shared libraries are sufficient in most cases. Signed-off-by: Bhabu Bindu <bindu.bhabukpit.com> Signed-off-by: Khem Raj <raj.khemgmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROCKSDB creates a STATIC library target reference by default.
Modify the cmake so that the STATIC library is also an option just like
creating a SHARED library but kept OFF by default.