[RocksJava] Memtables update to 3.6 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yhchiang i didnt port cukoo cause igorcanadi meant this kind of memtable is still experimental. As long as this feature is experimental and other mandatory features are not in i would like to skip porting it. |
|
@yhchiang shall i create a differential ? |
|
@fyrz: yes, you can skip cuckoo. |
fyrz
force-pushed
the
RocksJava-memtables-3.6
branch
3 times, most recently
from
4575340
to
ded61ba
Compare
|
@yhchiang anything new here ? |
- Adjusted HashLinkedList to 3.6.0 - Adjusted SkipList to 3.6.0 - Introduced a memtable test
fyrz
force-pushed
the
RocksJava-memtables-3.6
branch
from
ded61ba
to
9aa9668
Compare
yhchiang
added a commit
that referenced
this pull request
Oct 24, 2014
[RocksJava] Memtables update to 3.6
|
Nice catch-up. Thanks for the contribution! |
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
import snappy 1.1.4 and update bindings
suuyaoo
pushed a commit
to suuyaoo/rocksdb
that referenced
this pull request
Feb 29, 2024
* Add a blob-specific cache priority (facebook#10461) Summary: RocksDB's `Cache` abstraction currently supports two priority levels for items: high (used for frequently accessed/highly valuable SST metablocks like index/filter blocks) and low (used for SST data blocks). Blobs are typically lower-value targets for caching than data blocks, since 1) with BlobDB, data blocks containing blob references conceptually form an index structure which has to be consulted before we can read the blob value, and 2) cached blobs represent only a single key-value, while cached data blocks generally contain multiple KVs. Since we would like to make it possible to use the same backing cache for the block cache and the blob cache, it would make sense to add a new, lower-than-low cache priority level (bottom level) for blobs so data blocks are prioritized over them. This task is a part of facebook#10156 Pull Request resolved: facebook#10461 Reviewed By: siying Differential Revision: D38672823 Pulled By: ltamasi fbshipit-source-id: 90cf7362036563d79891f47be2cc24b827482743 * make format Signed-off-by: Connor1996 <zbk602423539@gmail.com> * make format Signed-off-by: Connor1996 <zbk602423539@gmail.com> --------- Signed-off-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Gang Liao <gangliao@cs.umd.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
make rocksdbjavamake jtest