Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues introduced by latest Java additions #357

Merged
merged 2 commits into from
Oct 25, 2014

Conversation

fyrz
Copy link
Contributor

@fyrz fyrz commented Oct 21, 2014

  • Makefile did not cleanup after test
  • Crossbuild sets explicit JDK6 which is wrong because Java7 dependencies were introduced lately.

@fyrz
Copy link
Contributor Author

fyrz commented Oct 21, 2014

@yhchiang can you please look at this.

@adamretter
Copy link
Collaborator

I see that the Travis-CI build is failing because of the test suite. This seems to be an intermittent problem, sometimes (but not always) when I run the test suite locally it also fails. I don't know if this is a test suite problem or an underlying Rocks issue. However I would suggest this should be fixed as a priority, if we can't rely on the test suite, well that is a a big problem.

@igorcanadi
Copy link
Collaborator

@adamretter We will fix it ASAP

@igorcanadi
Copy link
Collaborator

Fixed -- 90f1564

@igorcanadi
Copy link
Collaborator

@adamretter @fyrz can you guys add java test to travis build?

@adamretter
Copy link
Collaborator

@igorcanadi Thanks for the fix, I have sent a pull-request for Travis.

@fyrz
Copy link
Contributor Author

fyrz commented Oct 23, 2014

@igorcanadi can you merge this one also it solves some issues with the last additions.

@igorcanadi
Copy link
Collaborator

@adamretter can you please review @fyrz's patch? :)

@yhchiang
Copy link
Contributor

@fyrz: thanks for the patch. The diff looks good to me.
Not sure what goes wrong in Travis, but I can successfully build it on my machine.

yhchiang added a commit that referenced this pull request Oct 25, 2014
Fix issues introduced by latest Java additions
@yhchiang yhchiang merged commit bc3bc4b into facebook:master Oct 25, 2014
@fyrz fyrz deleted the JavaTest-Fix branch October 25, 2014 08:48
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants