set default value of memtable_whole_key_filtering to true #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
reviewed
Sep 4, 2019
| @@ -173,7 +173,7 @@ struct MutableCFOptions { | |||
| max_write_buffer_number(0), | |||
| arena_block_size(0), | |||
| memtable_prefix_bloom_size_ratio(0), | |||
| memtable_whole_key_filtering(false), | |||
| memtable_whole_key_filtering(true), | |||
There was a problem hiding this comment.
We also need to set a size ratio for it to take effective?
|
As a github commit message, "Per offline discussion" is going to be out of context. It will be better if the motivation is explicitly described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per offline discussion, default value of memtable_whole_key_filtering is now set to true
Test plan: make check