Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on variable name, closes #9488 #9495

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

theolivenbaum
Copy link
Contributor

No description provided.

Copy link
Contributor

@riversand963 riversand963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riversand963
Copy link
Contributor

@theolivenbaum thanks for the PR. Can you rebase onto facebook:main instead of master?

@theolivenbaum
Copy link
Contributor Author

Sure, will do tomorrow!

@riversand963 riversand963 added the waiting Waiting for a response from the issue creator. label Feb 18, 2022
@siying
Copy link
Contributor

siying commented May 6, 2022

I guess @riversand963 didn't receive the notification. So ping.

@riversand963
Copy link
Contributor

I guess @riversand963 didn't receive the notification. So ping.

The PR is still targeting facebook:master while it should be targeting facebook:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed waiting Waiting for a response from the issue creator.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants