Move all global state into YGConfig #446
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
May 3, 2017
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles #530 and #446 Closes #531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this issue
May 3, 2017
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles facebook/yoga#530 and facebook/yoga#446 Closes facebook/yoga#531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this issue
May 3, 2017
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles facebook/yoga#530 and facebook/yoga#446 Closes facebook/yoga#531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this issue
May 7, 2017
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles facebook/yoga#530 and facebook/yoga#446 Closes facebook/yoga#531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
makadaw
pushed a commit
to makadaw/react-native
that referenced
this issue
May 9, 2017
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles facebook/yoga#530 and facebook/yoga#446 Closes facebook/yoga#531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
|
Implemented. See #531 |
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this issue
May 9, 2018
Summary: Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node. Tackles facebook/yoga#530 and facebook/yoga#446 Closes facebook/yoga#531 Reviewed By: astreet Differential Revision: D4970149 Pulled By: emilsjolander fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Global state such as loggers and
gCurrentGenerationCountmake it hard to run Yoga in parallel as well as makes it hard to mix multiple frameworks both depending on Yoga. We can most likely move most of this state into the new YGConfig abstraction.The text was updated successfully, but these errors were encountered: