Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloatOptional GCC build fix and more constexpr #1411

Closed
wants to merge 22 commits into from
Closed

FloatOptional GCC build fix and more constexpr #1411

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c044926
Fix GCC Build
NickGerleman Oct 3, 2023
bf2bec8
Update FloatOptional.h
NickGerleman Oct 3, 2023
ced7f3a
Update Comparison.h
NickGerleman Oct 3, 2023
be71a9a
Update Comparison.h
NickGerleman Oct 3, 2023
7a8bed9
Update FloatOptionalTest.cpp
NickGerleman Oct 3, 2023
564c28b
Update FloatOptional.h
NickGerleman Oct 3, 2023
1499f55
Update FloatOptional.h
NickGerleman Oct 3, 2023
55fb80d
Update FloatOptional.h
NickGerleman Oct 3, 2023
7a487b3
Update Comparison.h
NickGerleman Oct 3, 2023
3db2b2f
Update Comparison.h
NickGerleman Oct 3, 2023
ff8fe7d
Update Comparison.h
NickGerleman Oct 3, 2023
6cbda6c
Update Comparison.h
NickGerleman Oct 4, 2023
28e74b0
Update FloatOptional.h
NickGerleman Oct 4, 2023
9c8ee3a
Update FloatOptional.h
NickGerleman Oct 4, 2023
fc7e026
Update FloatOptional.h
NickGerleman Oct 4, 2023
34d6ce5
Update FloatOptional.h
NickGerleman Oct 4, 2023
b5084fa
Update FloatOptional.h
NickGerleman Oct 4, 2023
b13d8d2
Update FloatOptional.h
NickGerleman Oct 4, 2023
4f68794
0.0f
NickGerleman Oct 4, 2023
e39f314
0.0f
NickGerleman Oct 4, 2023
c98a08e
0.0f
NickGerleman Oct 4, 2023
b065548
Update Comparison.h
NickGerleman Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FloatOptional.h
  • Loading branch information
@NickGerleman
NickGerleman committed Oct 4, 2023
commit 34d6ce53693c18564e66df9768c48d13f6ef05f0
6 changes: 3 additions & 3 deletions yoga/numeric/FloatOptional.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ constexpr bool operator<=(FloatOptional lhs, FloatOptional rhs) {
return lhs < rhs || lhs == rhs;
}

constexpr FloatOptional maxOrDefined(FloatOptional op1, FloatOptional op2) {
return FloatOptional{yoga::maxOrDefined(op1.unwrap(), op2.unwrap())};
constexpr FloatOptional maxOrDefined(FloatOptional a, FloatOptional b) {
return FloatOptional{yoga::maxOrDefined(a.unwrap(), b.unwrap())};
}

constexpr bool inexactEquals(const FloatOptional a, const FloatOptional b) {
constexpr bool inexactEquals(FloatOptional a, FloatOptional b) {
return yoga::inexactEquals(a.unwrap(), b.unwrap());
}

Expand Down
Loading