This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Modernizing the change dictionary to use the new string enum NSKeyValueChangeKey #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great modernization. Thank you! |
nlutsenko
approved these changes
Mar 2, 2017
|
Great! Thank you so much! Is it possible to publish a new Cocoapods version so that I can use it in my project? |
|
Sure, I don't see why not... What this means is that you might need to rebase this pul request on top of the master. |
|
Sounds good to me! Thank you so much for the quick responses! |
drkibitz
added a commit
to drkibitz/KVOController
that referenced
this pull request
Mar 7, 2017
rjstelling
pushed a commit
to MonikerSonic/KVOController
that referenced
this pull request
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it would help Swift bridging to use an enum for the change dictionary.