Implementation of some mmmdata_validation #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sumane81
reviewed
Sep 3, 2024
sumane81
reviewed
Sep 3, 2024
python/src/robyn/data/validation/calibration_input_validation.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 3, 2024
python/src/robyn/data/validation/calibration_input_validation.py
Outdated
Show resolved
Hide resolved
sumane81
reviewed
Sep 3, 2024
sumane81
reviewed
Sep 3, 2024
sumane81
reviewed
Sep 3, 2024
sumane81
reviewed
Sep 3, 2024
|
sumane81
reviewed
Sep 5, 2024
sumane81
reviewed
Sep 6, 2024
sumane81
reviewed
Sep 6, 2024
sumane81
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
This commit implements several validation methods in the MMMDataValidation class within mmmdata_validation.py. These methods are Python equivalents of the validation checks performed in the R version of Robyn, specifically in the checks.R file.
The implemented methods include:
check_missing_and_infinite: Checks for missing (NA) and infinite values in the input data.
check_no_variance: Identifies columns with no variance in the input data.
check_date_variable: Validates the date variable in the input data.
check_dependent_variables: Ensures the dependent variables are valid and of the correct type.
These implementations aim to maintain parity with the R version while adapting to Python's syntax and pandas DataFrame operations.
Fixes # (issue number, if applicable)
Type of change
How Has This Been Tested?
The code has been tested locally to ensure it runs without errors.
Unit tests for these methods will be added in a subsequent commit.
The implementations have been reviewed to ensure they match the functionality of the R version.
Note: This is part of an ongoing effort to port Robyn from R to Python. Additional validation methods will be implemented and committed based on feedback from this initial set of implementations.