Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python logger config #1044

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Adding python logger config #1044

merged 3 commits into from
Sep 5, 2024

Conversation

sumane81
Copy link

@sumane81 sumane81 commented Sep 5, 2024

Project Robyn

Added Python logger config.

  1. robyn/common/config/logger.conf contains logger configuration. Currently it is set to print INFO for both file and console handler
  2. log file will be created in current working directory of end usage. for example - log file will be created in tutorials directory if any tutorials is run. (not in working directory specified with instantiation of Robyn)
  3. CalibrationInputValidation was broken and it was blocker to test logger changes so fixing it here as well.

How Has This Been Tested?

image image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2024
alxlyj
alxlyj approved these changes Sep 5, 2024
View reviewed changes
Copy link

@alxlyj alxlyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sumane81 sumane81 merged commit 86f20be into robynpy_release Sep 5, 2024
4 checks passed
@sumane81 sumane81 deleted the robynpy_sandeep branch September 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivkanthb shivkanthb shivkanthb approved these changes

@alxlyj alxlyj alxlyj approved these changes

@Marco-Premier Marco-Premier Awaiting requested review from Marco-Premier

@stevenwarejones stevenwarejones Awaiting requested review from stevenwarejones

@gufengzhou gufengzhou Awaiting requested review from gufengzhou

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumane81 @shivkanthb @alxlyj @facebook-github-bot