Add new style allgather collective #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first "new style" collective that doesn't use the pattern where it is initialized once, holds some state, and is used many times. The new style is intended for use where collectives can be called at any time, such that initialization can no longer be amortized because reuse may no longer apply.
Like gather in the previous commit, this is a single function and doesn't hold on to any state. This implements a ring allgather.
teng-li
reviewed
Oct 12, 2018
| // Sanity checks | ||
| GLOO_ENFORCE(opts.elementSize > 0); | ||
| const auto recvRank = (context->size + context->rank - 1) % context->size; | ||
| GLOO_ENFORCE(context->getPair(recvRank), "pair missing (rank ", recvRank, ")"); |
There was a problem hiding this comment.
Maybe rephrasing pair missing to something that is easier to be understood
| // and the output buffer needs to be primed with the input. | ||
| if (in != nullptr) { | ||
| memcpy( | ||
| (uint8_t*) out->ptr + context->rank * opts.inElements * opts.elementSize, |
There was a problem hiding this comment.
pietern has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 23, 2018
Summary: This implements a ring reduction resulting the result scattered across processes, followed by a gather operation to the root process. The halving/doubling implementation is slated to be ported to this stateless style later and provided as an option through RedudeOptions. Rebase needed after #137 is merged. Pull Request resolved: #140 Reviewed By: manojkris Differential Revision: D10376422 Pulled By: pietern fbshipit-source-id: 2f32f693b8437cdff82a6528f18e576966984395
luciang
added a commit
to luciang/gloo
that referenced
this pull request
Apr 30, 2022
…age (facebookincubator#137) Summary: X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: c315a11e863b413a7662a497a3db71147488e782
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 30, 2022
…age (#137) Summary: X-link: facebook/CacheLib#137 Fix error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage] Reviewed By: philippv Differential Revision: D36043476 fbshipit-source-id: df3fa684c8655184dd8f87045542cd7f5704a65e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like gather in the previous commit, this is a single function and
doesn't hold on to any state. This implements a ring allgather.
Rebase needed after #136 is merged.