Add allgatherv #177
Closed
Add allgatherv #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 1, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: 2832f1b6338209d26d9860a5d07073d803170fe3
Closed
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 1, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: f503f9b72f23f3a07506837e767d38958829205c
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 1, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: 24404e6cd64ba0fd4b1f531c7c30bd68977b1c7a
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 1, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: 96622a2ea3bf94489ba178d5ea1e57936706b604
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 1, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: cab13b79ac96def5143989c5ee750e424e1435c8
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 3, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: 9b40aef89ea50921d9adabe052dd21f3e73860cb
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 7, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: 37a3774f418b06a2770f139a9995be83b4cc999a
pietern
added a commit
to pietern/gloo
that referenced
this pull request
May 9, 2019
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Differential Revision: D15174130 fbshipit-source-id: eac1338292672e51f7eb8b7500579744bbb21461
Summary: Pull Request resolved: facebookincubator#177 This addition includes a tweak to the unbound buffer default arguments. For allgatherv, it is valid for a process to contribute nothing, and `nbytes == 0` was special cased. Use a default value of UINT64_MAX to make `nbytes == 0` a valid call. Reviewed By: mrshenli Differential Revision: D15174130 fbshipit-source-id: 9dcf2b9923210de675bcfc390fb6dceab98e62de
|
This pull request has been merged in 6940167. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This addition includes a tweak to the unbound buffer default
arguments. For allgatherv, it is valid for a process to contribute
nothing, and
nbytes == 0was special cased. Use a default value ofUINT64_MAX to make
nbytes == 0a valid call.Differential Revision: D15174130