Fix instructions for installing benchmark #202
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@raminudelman Thanks for the patch. Can you put the PR into published mode / out of draft mode? Then I can import and merge it. |
|
@pietern I currently leave it in "draft mode" because I need to sign the CLA first, and I wait for my company's legal department to check everything there. |
|
@raminudelman Thanks for clarifying. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@pietern is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The
makecommand was missing to actually create the benchmark test.