Refactor algorithm tests to take transport parameter #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
pietern
added a commit
that referenced
this pull request
Aug 14, 2019
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent. ghstack-source-id: 46122ee90d31cd486e5fba23165d0b1d3f952a42 Pull Request resolved: #208
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
Closed
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
mrshenli
approved these changes
Aug 26, 2019
This is required to run the same algorithm tests against multiple transports. The test suite is comprised of both class algorithms and function algorithms. The former require fixed buffers, which are only supported on the tcp backend (and will be phased out). The latter require the unbound buffers, which are supported on both the tcp and uv (not yet merged) transports. This means we can't set the transport globally and forget about it, since it depends on the test whether or not it works with the selected transport. Instead, by parameterizing the tests we allow for multiple transports to be tested in the same test run. If a transport is not available (e.g. not compiled) then those tests can be skipped. Side notes: * There are a series of small modifications included here as well, including more consistent variable naming, and a more consistent usage of test parameterization generator functions. * Because this commit touches many lines anyway, I also ran clang-format on all files under `gloo/test` to make the style consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is required to run the same algorithm tests against multiple
transports. The test suite is comprised of both class algorithms and
function algorithms. The former require fixed buffers, which are only
supported on the tcp backend (and will be phased out). The latter
require the unbound buffers, which are supported on both the tcp and
uv (not yet merged) transports. This means we can't set the transport
globally and forget about it, since it depends on the test whether or
not it works with the selected transport.
Instead, by parameterizing the tests we allow for multiple transports
to be tested in the same test run. If a transport is not
available (e.g. not compiled) then those tests can be skipped.
Side notes:
including more consistent variable naming, and a more consistent
usage of test parameterization generator functions.
clang-format on all files under
gloo/testto make the styleconsistent.
Differential Revision: D17072673