Make localhost default device #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D26091783 |
Summary: Pull Request resolved: facebookincubator#283 "localhost" serves as a floating string constant throughout the gloo test codebase. Consolidating this into the `kDefaultDevice` constant. In the future, we could add this to a more generic utils header that all the tests import? Reviewed By: mingzhe09088 Differential Revision: D26091783 fbshipit-source-id: e9fa34805d93940215811008e9ad728fa778e553
|
This pull request was exported from Phabricator. Differential Revision: D26091783 |
osalpekar
force-pushed
the
export-D26091783
branch
from
46f96a2
to
bb6aa6e
Compare
|
This pull request has been merged in 415a7a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: "localhost" serves as a floating string constant throughout the gloo test codebase. Consolidating this into the
kDefaultDeviceconstant. In the future, we could add this to a more generic utils header that all the tests import?Differential Revision: D26091783