Automatically delete rendezvous files after a run #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D27028023 |
) Summary: Pull Request resolved: facebookincubator#300 The purpose of this diff is to automatically delete rendezvous files after the benchmark is done running. This way, the user does not have to manually delete the files in order to run the benchmark again. This is only relevant when the user uses `FileStore` to rendezvous (not Redis or MPI). `FileStore::set` takes in a key and generates a file based on the hash of this key. Added a new class variable `FileStore::rdzvFilePaths` which will store these paths. After calling `Context::connectFullMesh`, these paths will have been generated and we can call `FileStore::getRdzvFilePaths` to get the paths to delete at the end of the run. Change Summary: - Remove comments about deleting files - Add `rdzvFilePaths_` to `Runner` - Add `rdzvFilePaths` and `getRdzvFilePaths` to `FileStore` Reviewed By: osalpekar Differential Revision: D27028023 fbshipit-source-id: ada46990b8e8ae70d6dcd8c815ef1cd8cfc6d686
sofong5
force-pushed
the
export-D27028023
branch
from
800d7bb
to
0948dd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D27028023 |
|
This pull request has been merged in 1b62018. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The purpose of this diff is to automatically delete rendezvous files after the benchmark is done running. This way, the user does not have to manually delete the files in order to run the benchmark again. This is only relevant when the user uses
FileStoreto rendezvous (not Redis or MPI).FileStore::settakes in a key and generates a file based on the hash of this key. Added a new class variableFileStore::rdzvFilePathswhich will store these paths. After callingContext::connectFullMesh, these paths will have been generated and we can callFileStore::getRdzvFilePathsto get the paths to delete at the end of the run.Change Summary:
rdzvFilePaths_toRunnerrdzvFilePathsandgetRdzvFilePathstoFileStoreDifferential Revision: D27028023