Upgrade folly and other FB lib to v2023.08.07.00

Existing folly version uses OpenSSL@1.1, but setup-macos.sh would
install OpenSSL@3 as a dependency of Python. This causes the "make"
process failed with message "Undefined symbols for architecture x86_64:
"_EVP_MD_get_size"" because _EVP_MD_get_size was defined in OpenSSL@1.1
and was replaced by _EVP_MD_size in OpenSSL@3. CMake tries to link
against OpenSSL@3 and therefore the error.

Since the latest folly version is already on OpenSSL@3, upgrading
folly to the latest version solves the problem. This commit upgrades
Velox folly and other FB lib dependencies fizz, wangle, fbthrift to
version v2023.08.07.00.

scripts/setup-macos.sh

@@ -25,6 +25,9 @@
 # $ scripts/setup-macos.sh install_googletest install_fmt
 #
 
+INSTALL_PREREQUISITES="Y"
+PROMPT_ALWAYS_RESPOND="y"
+
 set -e # Exit on error.
 set -x # Print commands that are executed.
 
@@ -34,7 +37,7 @@ source $SCRIPTDIR/setup-helper-functions.sh
 NPROC=$(getconf _NPROCESSORS_ONLN)
 
 DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}
-MACOS_DEPS="ninja flex bison cmake ccache protobuf@21 icu4c boost gflags glog libevent lz4 lzo snappy xz zstd openssl@1.1"
+MACOS_DEPS="ninja flex bison cmake ccache protobuf@21 icu4c boost gflags glog libevent lz4 lzo snappy xz zstd openssl@3"
 
 function run_and_time {
   time "$@" || (echo "Failed to run $* ." ; exit 1 )
@@ -93,8 +96,8 @@ function install_fmt {
 }
 
 function install_folly {
-  github_checkout facebook/folly "v2022.11.14.00"
-  OPENSSL_ROOT_DIR=$(brew --prefix openssl@1.1) \
+  github_checkout facebook/folly "v2023.08.07.00"
+  OPENSSL_ROOT_DIR=$(brew --prefix openssl@3) \
   cmake_install -DBUILD_TESTS=OFF -DFOLLY_HAVE_INT128_T=ON
 }
 

scripts/setup-ubuntu.sh

@@ -23,7 +23,7 @@ source $SCRIPTDIR/setup-helper-functions.sh
 CPU_TARGET="${CPU_TARGET:-avx}"
 COMPILER_FLAGS=$(get_cxx_flags "$CPU_TARGET")
 export COMPILER_FLAGS
-FB_OS_VERSION=v2022.11.14.00
+FB_OS_VERSION=v2023.08.07.00
 NPROC=$(getconf _NPROCESSORS_ONLN)
 DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}
 export CMAKE_BUILD_TYPE=Release

velox/benchmarks/basic/ComparisonConjunct.cpp

@@ -175,7 +175,7 @@ BENCHMARK(conjunctsNested) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<ComparisonBenchmark>(1'000);

velox/benchmarks/basic/DecodedVector.cpp

@@ -188,7 +188,7 @@ BENCHMARK(decodeDictionary5Nested) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<DecodedVectorBenchmark>(10'000);

velox/benchmarks/basic/FeatureNormalization.cpp

@@ -110,7 +110,7 @@ BENCHMARK(normalizeConstant) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<FeatureNormailzationBenchmark>();

velox/benchmarks/basic/LikeFunctionsBenchmark.cpp

@@ -233,7 +233,7 @@ BENCHMARK(tpchQuery20) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv, true);
+  folly::Init(&argc, &argv, true);
   benchmark = std::make_unique<LikeFunctionsBenchmark>();
   folly::runBenchmarks();
   benchmark.reset();

velox/benchmarks/basic/Preproc.cpp

@@ -444,7 +444,7 @@ BENCHMARK(allFusedWithNulls) {
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   benchmark = std::make_unique<PreprocBenchmark>();
   // Verify that benchmark calculations are correct.

velox/benchmarks/basic/SelectivityVector.cpp

@@ -164,7 +164,7 @@ BENCHMARK(sumSelectivity1PerCent) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<SelectivityVectorBenchmark>(10'000);

velox/benchmarks/basic/SimpleArithmetic.cpp

@@ -343,7 +343,7 @@ BENCHMARK(plusCheckedLarge) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<SimpleArithmeticBenchmark>();

velox/benchmarks/basic/SimpleCastExpr.cpp

@@ -106,7 +106,7 @@ BENCHMARK(castTimestampDateAdjustTimeZone) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
   benchmark = std::make_unique<SimpleCastBenchmark>();
   folly::runBenchmarks();

velox/benchmarks/basic/VectorCompare.cpp

@@ -110,7 +110,7 @@ BENCHMARK_DRAW_LINE();
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmark = std::make_unique<VectorCompareBenchmark>(1000);

velox/benchmarks/basic/VectorFuzzer.cpp

@@ -128,7 +128,7 @@ BENCHMARK_RELATIVE_MULTI(flatMapArrayNested, n) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
   folly::runBenchmarks();
   return 0;

velox/benchmarks/basic/VectorSlice.cpp

@@ -110,7 +110,7 @@ DEFINE_BENCHMARKS(row)
 } // namespace facebook::velox
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   using namespace facebook::velox;
   gflags::ParseCommandLineFlags(&argc, &argv, true);
   VELOX_CHECK_LE(FLAGS_slice_size, kVectorSize);

velox/benchmarks/tpch/TpchBenchmarkMain.cpp

@@ -23,6 +23,6 @@ int main(int argc, char** argv) {
   std::string kUsage(
       "This program benchmarks TPC-H queries. Run 'velox_tpch_benchmark -helpon=TpchBenchmark' for available options.\n");
   gflags::SetUsageMessage(kUsage);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   tpchBenchmarkMain();
 }

velox/benchmarks/unstable/MemoryAllocationBenchmark.cpp

@@ -435,7 +435,7 @@ BENCHMARK_RELATIVE_MULTI(MmapReallocateMix64) {
 } // namespace
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   // TODO: add to run benchmark as a standalone program with multithreading as
   // well as actual memory access to trigger minor page faults in OS which traps
   // into kernel context to setup physical pages for the lazy-mapped virtual

velox/common/base/benchmarks/BitUtilBenchmark.cpp

@@ -191,7 +191,7 @@ BENCHMARK_RELATIVE_MULTI(forEachBitFirstBitFalse) {
 } // namespace facebook
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/common/base/tests/Memcpy.cpp

@@ -58,7 +58,7 @@ struct CopyCallable {
 
 int main(int argc, char** argv) {
   constexpr int32_t kAlignment = folly::hardware_destructive_interference_size;
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   auto chunk = bits::roundUp(
       std::max<int64_t>(FLAGS_bytes / FLAGS_threads, kAlignment), kAlignment);
   int64_t bytes = chunk * FLAGS_threads;

velox/common/base/tests/StatsReporterTest.cpp

@@ -130,7 +130,7 @@ folly::Singleton<BaseStatsReporter> reporter([]() {
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   facebook::velox::BaseStatsReporter::registered = true;
   return RUN_ALL_TESTS();
 }

velox/common/file/benchmark/ReadBenchmarkMain.cpp

@@ -24,7 +24,7 @@ using namespace facebook::velox;
 // and the IO throughput is 100 MBps, then it takes 10 seconds to just read the
 // data.
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   ReadBenchmark bm;
   bm.initialize();
   bm.run();

velox/common/memory/tests/MemoryPoolBenchmark.cpp

@@ -239,7 +239,7 @@ BENCHMARK(FlatSticks, iters) {
 }
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/connectors/fuzzer/tests/FuzzerConnectorTest.cpp

@@ -124,6 +124,6 @@ TEST_F(FuzzerConnectorTest, reproducible) {
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/connectors/hive/benchmarks/HivePartitionFunctionBenchmark.cpp

@@ -267,7 +267,7 @@ BENCHMARK_DRAW_LINE();
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   gflags::ParseCommandLineFlags(&argc, &argv, true);
 
   benchmarkFew = std::make_unique<HivePartitionFunctionBenchmark>(1'000);

velox/connectors/hive/storage_adapters/gcs/benchmark/GCSReadBenchmarkMain.cpp

@@ -24,7 +24,7 @@ using namespace facebook::velox;
 // and the IO throughput is 100 MBps, then it takes 10 seconds to just read the
 // data.
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   GCSReadBenchmark bm;
   bm.initialize();
   bm.run();

velox/connectors/hive/storage_adapters/s3fs/benchmark/S3ReadBenchmarkMain.cpp

@@ -24,7 +24,7 @@ using namespace facebook::velox;
 // and the IO throughput is 100 MBps, then it takes 10 seconds to just read the
 // data.
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   S3ReadBenchmark bm;
   bm.initialize();
   bm.run();

velox/connectors/tpch/tests/SpeedTest.cpp

@@ -179,7 +179,7 @@ class TpchSpeedTest {
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
 
   TpchSpeedTest speedTest;
   speedTest.run(

velox/connectors/tpch/tests/TpchConnectorTest.cpp

@@ -287,6 +287,6 @@ TEST_F(TpchConnectorTest, orderDateCount) {
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/dwio/common/tests/BitPackDecoderBenchmark.cpp

@@ -412,7 +412,7 @@ void naiveDecodeBitsLE(
 }
 
 int32_t main(int32_t argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   // Populate uint32 buffer
 

velox/dwio/common/tests/DataBufferBenchmark.cpp

@@ -53,7 +53,7 @@ BENCHMARK(ChainedBufferOps, iters) {
 }
 
 int main(int argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/dwio/common/tests/IntDecoderBenchmark.cpp

@@ -939,7 +939,7 @@ BENCHMARK_RELATIVE(decodeNew_64) {
 }
 
 int32_t main(int32_t argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   // Populate uint16 buffer
   buffer_u16.resize(kNumElements);

velox/dwio/dwrf/test/E2EFilterTest.cpp

@@ -410,6 +410,6 @@ TEST_F(E2EFilterTest, mutationCornerCases) {
 // Define main so that gflags get processed.
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/dwio/dwrf/test/FloatColumnWriterBenchmark.cpp

@@ -130,7 +130,7 @@ BENCHMARK(FloatColumnWriterBenchmark10000) {
 }
 
 int32_t main(int32_t argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/dwio/dwrf/test/IntEncoderBenchmark.cpp

@@ -204,7 +204,7 @@ BENCHMARK_RELATIVE(GenerateAutoIdNew_64) {
 }
 
 int32_t main(int32_t argc, char* argv[]) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/dwio/parquet/tests/ParquetTpchTest.cpp

@@ -113,6 +113,6 @@ TEST_F(ParquetTpchTest, Q22) {
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/dwio/parquet/tests/reader/E2EFilterTest.cpp

@@ -616,6 +616,6 @@ TEST_F(E2EFilterTest, combineRowGroup) {
 // Define main so that gflags get processed.
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/dwio/parquet/tests/reader/ParquetReaderBenchmark.cpp

@@ -374,7 +374,7 @@ PARQUET_BENCHMARKS_NO_FILTER(ARRAY(BIGINT()), List);
 // TODO: Add all data types
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   folly::runBenchmarks();
   return 0;
 }

velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp

@@ -446,6 +446,6 @@ TEST_F(ParquetTableScanTest, readAsLowerCase) {
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/dwio/parquet/tests/thrift/ThriftTransportTest.cpp

@@ -106,6 +106,6 @@ TEST_F(ThriftTransportTest, bufferedOutOfBoundry) {
 // Define main so that gflags get processed.
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
-  folly::init(&argc, &argv, false);
+  folly::Init(&argc, &argv, false);
   return RUN_ALL_TESTS();
 }

velox/examples/OperatorExtensibility.cpp

@@ -160,7 +160,7 @@ class DuplicateRowTranslator : public exec::Operator::PlanNodeTranslator {
 };
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   // Fourth, we register the custom plan translator. We're now ready to use our
   // operator in a query plan.

velox/examples/ScanAndSort.cpp

@@ -42,7 +42,7 @@ using exec::test::HiveConnectorTestBase;
 int main(int argc, char** argv) {
   // Velox Tasks/Operators are based on folly's async framework, so we need to
   // make sure we initialize it first.
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   // Default memory allocator used throughout this example.
   auto pool = memory::addDefaultLeafMemoryPool();

velox/examples/ScanOrc.cpp

@@ -31,7 +31,7 @@ using namespace facebook::velox::dwrf;
 // Used to compare the ORC data read by DWRFReader against apache-orc repo.
 // Usage: velox_example_scan_orc {orc_file_path}
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
 
   if (argc < 2) {
     return 1;

velox/exec/benchmarks/ExchangeBenchmark.cpp

@@ -331,7 +331,7 @@ BENCHMARK(localFlat10k) {
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   functions::prestosql::registerAllScalarFunctions();
   aggregate::prestosql::registerAllAggregateFunctions();
   parse::registerTypeResolver();

velox/exec/benchmarks/FilterProjectBenchmark.cpp

@@ -266,7 +266,7 @@ class FilterProjectBenchmark : public VectorTestBase {
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   functions::prestosql::registerAllScalarFunctions();
   aggregate::prestosql::registerAllAggregateFunctions();
   parse::registerTypeResolver();

velox/exec/benchmarks/HashTableBenchmark.cpp

@@ -611,7 +611,7 @@ void combineResults(
 } // namespace
 
 int main(int argc, char** argv) {
-  folly::init(&argc, &argv);
+  folly::Init(&argc, &argv);
   memory::MmapAllocator::Options options;
   options.capacity = 10UL << 30;
   options.useMmapArena = true;