Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix compareMaterializedRows to check all rows in two sets are equal (#…
…3725) Summary: Pull Request resolved: #3725 There is a bug in compareMaterializedRows(left, right) that compares two result sets left and right. It currently only check that all rows in left can be found in right, but not the other way around. Hence it would miss the cases like left = {1, 1, 2} and right = {1, 2, 3}. This diff fixes this bug by adding the check the other way around. This fix discovered an error in the MultiFragmentTest.limit unit test (#3726) where the input vector contains nulls every 7 indices, whereas the expected result given in the test that contains null only at index 0 is incorrect. This diff also fixes this bug in the test. Reviewed By: Yuhta, mbasmanova Differential Revision: D42551023 fbshipit-source-id: 86595cf269be8190a5e19bb7edb6cc4f90bcb083
- Loading branch information