Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semi projection join type in smj #10456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JkSelf
Copy link
Collaborator

@JkSelf JkSelf commented Jul 12, 2024

Return each row from the left or right side with a boolean flag indicating whether there exists a match on the right or left side. If there is a filter, the boolean value will be set based on the result of the filter in the applyFilter method. If there is no filter, the filterOutputForSemiProject is added to set the boolean value based on the records in joinTracker's matchingRows.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2024
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b460dc5
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6706302253d3530008c9d084

@JkSelf
Copy link
Collaborator Author

JkSelf commented Sep 18, 2024

@pedroerp Can you help to review this PR? Thanks for your help.

Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JkSelf could you add more context on what exactly is needed to support semi projection joins to the summary, and some documentation on the file header?

@JkSelf
Copy link
Collaborator Author

JkSelf commented Oct 9, 2024

@JkSelf could you add more context on what exactly is needed to support semi projection joins to the summary, and some documentation on the file header?

@pedroerp Yes. I have refine the summary and also add the comments in the header file. Can you help to review again? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants