Add support for "week of month" in SimpleDateTimeFormatter #11103
+205
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
NEUpanning
force-pushed
the
support_week_of_month_newest
branch
from
4a95917
to
a3205d0
Compare
|
@rui-mo Could you help to review this PR please? Thanks. |
This was referenced Sep 26, 2024
rui-mo
reviewed
Oct 10, 2024
| bool centuryFormat = false; | ||
|
|
||
| bool isYearOfEra = false; // Year of era cannot be zero or negative. | ||
| bool hasYear = false; // Whether year was explicitly specified. | ||
| bool hasYear = false; |
There was a problem hiding this comment.
nit: is the comment Whether year was explicitly specified. removed by accident?
There was a problem hiding this comment.
Thanks for catching that. Updated.
| bool hasYear = false; // Whether year was explicitly specified. | ||
| bool hasYear = false; | ||
| // Whether dayOfWeek was explicitly specified. | ||
| bool hasDayOfWeek = false; |
There was a problem hiding this comment.
nit: perhaps follow the style of other comments to add comment after the code.
| if (!date.weekOfMonthDateFormat) { | ||
| date.weekDateFormat = true; | ||
| } | ||
| date.hasDayOfWeek = true; |
There was a problem hiding this comment.
nit: perhaps put it near L1001.
|
@rui-mo I've updated code based on the feedback. Could you review it again? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.text.SimpleDateFormatsupports using 'week of month' to parse/format date. The specifier of 'week of month' is 'W'. Now DateTimeFormatter supports 3 group of fields specifying the day within the year. They are following combinations:This PR introduces a new combination that is
year + month + weekOfMonth + dayOfWeekand adds support for "week of month" in SimpleDateTimeFormatter.Relates issue : #10354