Invalid format returns null for legacy date formatter #11131
+198
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
17 tasks
|
@rui-mo Could you help to review this PR please? Thanks. |
rui-mo
reviewed
Oct 10, 2024
| kDefaultFormat_, | ||
| config.sparkLegacyDateFormatter() ? DateTimeFormatterType::STRICT_SIMPLE | ||
| : DateTimeFormatterType::JODA); | ||
| // Default format should always be valid. | ||
| VELOX_CHECK_EQ(formatter.hasError(), false); |
There was a problem hiding this comment.
VELOX_CHECK(!formatter.hasError());
There was a problem hiding this comment.
Thanks. Updated.
| invalidFormat_ = true; | ||
| } else { | ||
| this->format_ = formatter.value(); | ||
| } | ||
| } catch (const VeloxUserError&) { |
There was a problem hiding this comment.
I wound be nice to make buildJodaDateTimeFormatter return Expected so getDateTimeFormatter does not throw exception and the try-catch clause can be removed.
There was a problem hiding this comment.
Thanks for your suggestion. Done.
| std::string_view(format.data(), format.size()), | ||
| legacyFormatter_ ? DateTimeFormatterType::STRICT_SIMPLE | ||
| : DateTimeFormatterType::JODA); | ||
| if (formatter.hasError()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Exception from 'buildJodaDateTimeFormatter' is not handled, so it shall work here if 'buildJodaDateTimeFormatter' returns Expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid format returns null for Spark functions that use legacy(Simple) date formatter to align with SparkSQL behavior. Included functions are : 'unix_timestamp', 'from_unixtime' and 'get_timestamp'.
Relates #10354