PhabricatorVersion245726248 #11142
Closed
PhabricatorVersion245726248 #11142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63711984 |
|
This pull request was exported from Phabricator. Differential Revision: D63711984 |
kevinwilfong
force-pushed
the
export-D63711984
branch
from
4cf08cc
to
2bcdf6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63711984 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 1, 2024
…r#11142) Summary: Pull Request resolved: facebookincubator#11142 With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63711984
kevinwilfong
force-pushed
the
export-D63711984
branch
from
2bcdf6d
to
350732c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63711984 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 1, 2024
…r#11142) Summary: Pull Request resolved: facebookincubator#11142 With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63711984
kevinwilfong
force-pushed
the
export-D63711984
branch
from
350732c
to
fcd69a8
Compare
bikramSingh91
approved these changes
Oct 3, 2024
| {0}, | ||
| makeNullableFlatVector<int64_t>( | ||
| expectedAscArray, TIMESTAMP_WITH_TIME_ZONE())); | ||
| const auto expectedDesc = makeArrayVector( |
There was a problem hiding this comment.
nit: Would Array<Row> also work (similar to the test case added in array_max/min)? If yes, then apart from adding this case here we can also test the array_sort with lambda here like array_sort(c0, x -> x.c0)
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 3, 2024
…r#11142) Summary: With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Reviewed By: bikramSingh91 Differential Revision: D63711984
added 2 commits
October 7, 2024 12:14
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
…r#11142) Summary: With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Reviewed By: bikramSingh91 Differential Revision: D63711984
kevinwilfong
force-pushed
the
export-D63711984
branch
from
fcd69a8
to
8f06c64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63711984 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 7, 2024
…r#11142) Summary: With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Reviewed By: bikramSingh91 Differential Revision: D63711984
|
This pull request has been merged in 641193b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With #11136 array_sort just works with
TimestampWithTimezone.
Adding unit tests to verify this and ensure it doesn't break in the future.
Differential Revision: D63711984