-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HashAggregation Replayer #11176
Add HashAggregation Replayer #11176
Conversation
✅ Deploy Preview for meta-velox canceled.
|
e332b68
to
204b90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duanmeng LGTM % nits. Thanks!
static std::string usage(); | ||
|
||
protected: | ||
virtual core::PlanNodePtr createPlan() const = 0; | ||
private: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected?
const auto* replayNode = core::PlanNode::findFirstNode( | ||
planFragment_.get(), | ||
[this](const core::PlanNode* node) { return node->id() == nodeId_; }); | ||
const auto traceRoot = fmt::format("{}/{}", rootDir_, taskId_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/traceRoot/traceDir/
static core::PlanNodePtr createTableWrtierNode( | ||
const core::TableWriteNode* node, | ||
const std::string& targetDir, | ||
core::PlanNodePtr createRepalyNode( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/createRepalyNode/createPlanNode/
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@xiaoxmeng merged this pull request in 74c2133. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Records input in
HashAggregation
and AggregationReplayer to support the replaying.part of #9668