Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use envvar for DuckDB version in setup script #11207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use envvar for DuckDB version in setup script #11207

wants to merge 2 commits into from
+6 −3

Conversation

JackyWoo
Copy link

@JackyWoo JackyWoo commented Oct 9, 2024

Changelog

Make duckdb version an versiable

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b11a35f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6707516faeff48000821c94e

@assignUser assignUser changed the title Make duckdb version an versiable Use envvar for DuckDB version in setup script Oct 10, 2024
assignUser
assignUser requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change but please also add the change to the other setup scripts aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser requested changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackyWoo @assignUser @facebook-github-bot