Add decimal types support to VELOX_DYNAMIC_TYPE_DISPATCH_IMPL #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
CC: @karteekmurthys |
majetideepak
changed the title
|
@laithsakka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
majetideepak
force-pushed
the
extend-decimal-template
branch
from
df56967
to
7c51f6a
Compare
✅ Deploy Preview for meta-velox canceled.
|
|
@laithsakka @kgpai can you please import this again? I had to rebase due to a conflict with the main branch. Thanks. |
majetideepak
force-pushed
the
extend-decimal-template
branch
from
7c51f6a
to
b2b948e
Compare
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kevinwilfong
reviewed
Sep 6, 2022
velox/type/Variant.cpp
Outdated
Comment on lines
88
to
89
| if (!lType->equivalent(*rType)) | ||
| return false; |
There was a problem hiding this comment.
Hi, we use ClangTidy internally which enforces that braces are used for all if statements, even these single line ones. Plus it helps with readability and it's defensive agains accidental bugs.
Could you add braces here?
velox/type/Variant.cpp
Outdated
| const auto rhs = b.value<TypeKind::LONG_DECIMAL>(); | ||
| const auto lType = DECIMAL(lhs.precision, lhs.scale); | ||
| const auto rType = DECIMAL(rhs.precision, rhs.scale); | ||
| if (!lType->equivalent(*rType)) |
majetideepak
force-pushed
the
extend-decimal-template
branch
from
b2b948e
to
333722a
Compare
majetideepak
force-pushed
the
extend-decimal-template
branch
from
333722a
to
9b4d659
Compare
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lingbin
added a commit
to lingbin/velox
that referenced
this pull request
Sep 29, 2022
`VELOX_DYNAMIC_TYPE_DISPATCH_IMPL` macro already support decimal types in facebookincubator#2307, so there is also no need to specialize decimal types in `VELOX_DYNAMIC_TYPE_DISPATCH_METHOD_ALL` macro.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Summary: `VELOX_DYNAMIC_TYPE_DISPATCH_IMPL` macro already supports decimal types in #2307, so there is also no need to specialize decimal types in `VELOX_DYNAMIC_TYPE_DISPATCH_METHOD_ALL` macro. Pull Request resolved: #2680 Reviewed By: Yuhta Differential Revision: D39926371 Pulled By: mbasmanova fbshipit-source-id: 36a627093b2c44d401a4781e45d85b0bfe16bcdf
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lack of VELOX_DYNAMIC_TYPE_DISPATCH_IMPL support for decimal types
requires specialization for these types at various code blocks.
This is now supported.