pass ExecCtx and result by reference to apply() #2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38968157 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D38968157 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 24, 2022
Summary: Pull Request resolved: facebookincubator#2376 instead of passing pointer to VectorPtr and pointer to context the change pass those by ref, since they should never be passed as null. For the same reason, the diff also make the result vector argument of ensureWritable a reference instead of a pointer to pointer and also construction arguments of LocalDecodedVectors Differential Revision: D38968157 fbshipit-source-id: 10d977abd751a77a56ce8bef7bf3a4a6a4de9ac5
laithsakka
force-pushed
the
export-D38968157
branch
from
00473c4
to
a2ef085
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38968157 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 25, 2022
Summary: Pull Request resolved: facebookincubator#2376 instead of passing pointer to VectorPtr and pointer to context the change pass those by ref, since they should never be passed as null. For the same reason, the diff also make the result vector argument of ensureWritable a reference instead of a pointer to pointer and also construction arguments of LocalDecodedVectors Differential Revision: D38968157 fbshipit-source-id: 1a98172185d6dc856127a285165dbe85c2056be1
laithsakka
force-pushed
the
export-D38968157
branch
from
a2ef085
to
11e6323
Compare
Summary: Pull Request resolved: facebookincubator#2376 instead of passing a pointer to VectorPtr and a pointer to the context the change passes those by ref since they should never be passed as null. For the same reason, the diff also makes the result vector argument of ensureWritable a reference instead of a pointer to pointer and also constructor arguments of LocalDecodedVectors. Reviewed By: kagamiori Differential Revision: D38968157 fbshipit-source-id: 02a9c3d7699090aef8e572af6ca1173086b4e860
laithsakka
force-pushed
the
export-D38968157
branch
from
11e6323
to
42572fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38968157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
instead of passing pointer to VectorPtr and pointer to context
the change pass those by ref, since they should never be passed as null.
For the same reason, the diff also make the result vector argument of ensureWritable a reference instead of a pointer to pointer and also
construction arguments of LocalDecodedVectors
Differential Revision: D38968157