Add json_format Presto function (#3398) #3525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 15, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 6b652de2fda6abff7bbde3465307de5fdf311787
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
0dd09cc
to
067ccde
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 15, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 095c3bb32951b1578476040b0556425f77e29e6a
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
067ccde
to
523918a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
mbasmanova
reviewed
Dec 15, 2022
There was a problem hiding this comment.
@arpitporwal2293 Looks good to me. Please, run Fuzzer tests as described in https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#prestos-sql-functions and report the results.
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 16, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 7806d25d21ddff541e428b8f1077d6375bd30154
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
523918a
to
c53c6b6
Compare
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 20, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 4e59f9ce0de8135d3b046432cc591a6e73561d96
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
c53c6b6
to
edf57a2
Compare
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 20, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 03b6db4247042fd732c1c32f4ef95cd47a828a68
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
edf57a2
to
ceb43b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 21, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 9044a8a1d69c7abab51d95ea64384f5a877c7698
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
ceb43b8
to
17c9703
Compare
mbasmanova
reviewed
Dec 21, 2022
There was a problem hiding this comment.
@arpitporwal2293 Thank you for iterating on this PR. Some comments.
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: eeaf6d49328d3e194eb3847be38f71f2f9ae0a6d
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
17c9703
to
ee33bea
Compare
mbasmanova
reviewed
Dec 22, 2022
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: d4bdf41a86d435acd519a4ece105bb0cec4002bd
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
ee33bea
to
3a19b10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 4d747d7974f10cda4831d4008312a166de626cd2
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
3a19b10
to
25f8ad3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
mbasmanova
approved these changes
Dec 22, 2022
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
25f8ad3
to
45dafee
Compare
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: b12fe8c0c2a1757adbe446fd3943283311dbb13a
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: 4db561f302534cf9661bd086e161d83c9b0dbfc0
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
45dafee
to
7bd982c
Compare
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: 806f9a2b8d20ee23558ee2f72112d8f33ac289ac
arpitporwal2293
force-pushed
the
export-D42060671
branch
from
7bd982c
to
76ec7cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42060671 |
|
This pull request has been merged in 05e5aae. |
marin-ma
added a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format
Differential Revision: D42060671