Upgrade folly to v2023.08.07.00 for MacOS #6093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
yingsu00
force-pushed
the
folly
branch
5 times, most recently
from
8791222
to
17e6f81
Compare
Existing folly version uses OpenSSL@1.1, but setup-macos.sh would install OpenSSL@3 as a dependency of Python. This causes the "make" process failed with message "Undefined symbols for architecture x86_64: "_EVP_MD_get_size"" because _EVP_MD_get_size was defined in OpenSSL@1.1 and was replaced by _EVP_MD_size in OpenSSL@3. CMake tries to link against OpenSSL@3 and therefore the error. Since the latest folly version is already on OpenSSL@3, upgrading folly to the latest version solves the problem. This commit upgrades Velox folly and other FB lib dependencies fizz, wangle, fbthrift to version v2023.08.07.00.
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing folly version uses OpenSSL@1.1, but setup-macos.sh would install OpenSSL@3 as a dependency of Python. This causes the "make" process failed with message "Undefined symbols for architecture x86_64: "_EVP_MD_get_size"" because _EVP_MD_get_size was defined in OpenSSL@1.1 and was replaced by _EVP_MD_size in OpenSSL@3. CMake tries to link against OpenSSL@3 and therefore the error.
Since the latest folly version is already on OpenSSL@3, upgrading folly to the latest version solves the problem. This commit upgrades Velox folly dependency to version v2023.08.07.00.