Add OderBy output stage spill #7759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
duanmeng
force-pushed
the
obspill
branch
7 times, most recently
from
4a6013c
to
b96d687
Compare
xiaoxmeng
reviewed
Nov 30, 2023
velox/exec/Spiller.h
Outdated
| /// Invoked to spill.Spill all rows pointed by the pointers in sortedRows.This | ||
| /// is only used by 'kOrderByOutput' spiller type to spill during the order by | ||
| /// output processing. Similarly, the spilled rows still stays in the row | ||
| /// container.The caller needs to erase them from the row container. |
There was a problem hiding this comment.
s/container.The/container. The/
01583a8
to
a981427
Compare
|
@xiaoxmeng Hi Xuan, I've made a small refactor and resolved all your comments. Could you please help take another look? Thanks. |
duanmeng
force-pushed
the
obspill
branch
3 times, most recently
from
6b0400a
to
551b3b5
Compare
xiaoxmeng
reviewed
Dec 7, 2023
|
@xiaoxmeng Hi Xuan, thanks for your review and guidance, I've resolved all the comments, could you please help to take a look? |
xiaoxmeng
approved these changes
Dec 7, 2023
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in ddc3471. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
yma11
added a commit
to yma11/velox
that referenced
this pull request
Dec 8, 2023
This reverts commit ddc3471.
zhztheplayer
added a commit
to zhztheplayer/velox
that referenced
this pull request
Dec 11, 2023
This reverts commit ddc3471.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new type of spiller named
kOrderByOutput.It is used to spill data during the output processing
stage of
OrderByoperator. The spiller uses a newlyadded API that supports spill data by row pointers.