Expand push_back for arrayWriter support to generics and strings. #8334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52672124 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Jan 10, 2024
…cebookincubator#8334) Summary: This simply functions alot in two ways: - one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(item); - since primitive and generic with this have same interface many duplicate of functions wont be needed. (See examples in the diff). Differential Revision: D52672124
laithsakka
force-pushed
the
export-D52672124
branch
from
5afaa5b
to
699454e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52672124 |
laithsakka
force-pushed
the
export-D52672124
branch
from
699454e
to
3f58877
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52672124 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Jan 10, 2024
…cebookincubator#8334) Summary: This simply functions alot in two ways: 1. one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]); 2. since primitive and generic with this have same interface many duplicate of functions wont be needed. Differential Revision: D52672124
laithsakka
force-pushed
the
export-D52672124
branch
from
3f58877
to
896ff37
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52672124 |
…cebookincubator#8334) Summary: This simply functions alot in two ways: 1. one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]); 2. since primitive and generic with this have same interface many duplicate of functions wont be needed. Differential Revision: D52672124
laithsakka
force-pushed
the
export-D52672124
branch
from
896ff37
to
3d9b736
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52672124 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Jan 10, 2024
…cebookincubator#8334) Summary: This simplify functions in two ways: 1. one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]); 2. since primitive and generic with this have same interface many duplicate of functions wont be needed. Differential Revision: D52672124
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Jan 10, 2024
…cebookincubator#8334) Summary: This simplify functions in two ways: 1. one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]); 2. since primitive and generic with this have same interface many duplicate of functions wont be needed. Differential Revision: D52672124
|
This pull request has been merged in 5e38168. |
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Jan 16, 2024
…cebookincubator#8334) Summary: Pull Request resolved: facebookincubator#8334 This simplify functions in two ways: - one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]);. - since primitive and generic with this have same interface many duplicate of functions body wont be needed. Reviewed By: amitkdutta Differential Revision: D52672124 fbshipit-source-id: 1397461b59a82d7aec99d762e6f1c955191df55a
mbasmanova
pushed a commit
to mbasmanova/velox-1
that referenced
this pull request
Jan 17, 2024
…cebookincubator#8334) Summary: Pull Request resolved: facebookincubator#8334 This simplify functions in two ways: - one common pattern in functions is ``` if (inputArray[i].has_value()) { auto& newItem = out.add_item(); newItem.copy_from(inputArray[i].value()); } else { out.add_null(); } ```` now can be done in one line out.push_back(inputArray[i]);. - since primitive and generic with this have same interface many duplicate of functions body wont be needed. Reviewed By: amitkdutta Differential Revision: D52672124 fbshipit-source-id: 1397461b59a82d7aec99d762e6f1c955191df55a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This simplify functions in two ways:
now can be done in one line
out.push_back(inputArray[i]);
Differential Revision: D52672124