Enable result validation for collect_list Spark function in the Fuzzer #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
liujiayi771
changed the title
mbasmanova
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
@liujiayi771 Thank you for improving test coverage for the new aggregate function.
mbasmanova
changed the title
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 3e702c7. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
facebookincubator#9361) Summary: In facebookincubator#9231, `collect_list` is added to the disable list of `duckQueryRunner`. However, this is unnecessary because DuckDB does not have an aggregate function named `collect_list`, hence it would not be compared against DuckDB. This setting is redundant. Other than this, the results verification of `collect_list` has been set to `nullptr`, so its results are not verified. But we can use a custom array verifier used by Presto's `array_agg` to check the results of itself. Pull Request resolved: facebookincubator#9361 Reviewed By: xiaoxmeng Differential Revision: D55744044 Pulled By: mbasmanova fbshipit-source-id: a1a94c58b2a01463261775d8b6e08b65fd986d29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9231,
collect_listis added to the disable list ofduckQueryRunner.However, this is unnecessary because DuckDB does not have an aggregate function
named
collect_list, hence it would not be compared against DuckDB. Thissetting is redundant.
Other than this, the results verification of
collect_listhas been set tonullptr, so its results are not verified. But we can use a custom arrayverifier used by Presto's
array_aggto check the results of itself.