This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix detect_offensive_language script
#4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilydinan
reviewed
Oct 6, 2021
| @@ -81,6 +81,8 @@ def report(world, stats): | |||
| return log | |||
|
|
|||
| def classify(text, stats): | |||
| if not text: | |||
There was a problem hiding this comment.
i wonder if the right answer here is to just make our utils in utils/safety.py robust to empty text
There was a problem hiding this comment.
that's fair, would catch it at the source...
|
Updated the PR to make |
|
This PR has not had activity in 30 days. Closing due to staleness. |
klshuster
added
donotreap
|
bump |
|
bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The script would break if the
labelsortextfields within a task were empty strings; this fixes that.I'm not really sure who to tag on this as a reviewer so lmk if someone else should review.
Testing steps
See #4049 for task that breaks the script. I've also added a new test to confirm this works.