Uses python -m pip style for installation #177
Conversation
facebook-github-bot
added
the
CLA Signed
|
I wanted to say "not needed because virtualenv" but that link was pretty convincing. |
|
I hope one of the maintainers will see and approve. Should not take that much time as it is a much simple PR without code change. |
|
@kushaldas sorry about that, but due to a bug in HF Transformers, CI is currently failling (not your fault). However, you would have to pull and merge from main and push again before we can accept. |
|
Can you ensure you're up to date with respect to main? There were some issues with Hugging Face Transformers library that required extra dependencies that is now fixed in main. Then we'll be able to merge. Thank you! |
|
I updated the PR last week. Commenting as just in case :) |
|
Some (unrelated?) lint error on CI:
|
|
Can anyone please tell me what needs to be done here? |
|
Woo hoo, can anyone please rerun the CI job and then accept the PR? |
|
Will these CI jobs ever finish? |
|
@adefossez @JadeCopet can anyone of you please run/kick the CI as required? |
|
Since @adefossez has left Meta for a new industry lab, I imagine we won't see much reviewing here. Would be nice to know the future of AudioCraft as a package! |
|
Who can merge?!!! :) |
|
Hey @kushaldas, sorry for the late response. I had to fix the CI jobs on main, you can merge our main and then we should be good to land this. |
Updates the readme to use `python -m pip install` style for installing python packages. This is what we suggest at upstream to reduce the confusion of which Python interpreter is being used. See more: https://snarky.ca/why-you-should-use-python-m-pip/
|
Thank you again! |
|
Yay!!! Thank you @JadeCopet :) |
Updates the readme to use
python -m pip installstyle for installing python packages. This is what we suggest at upstream to reduce the confusion of which Python interpreter is being used.See more: https://snarky.ca/why-you-should-use-python-m-pip/