Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter in CI + set PyTorch version #352

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix linter in CI + set PyTorch version #352

merged 2 commits into from
Nov 21, 2023

Conversation

JadeCopet
Copy link
Contributor

@JadeCopet JadeCopet commented Nov 21, 2023 •
edited
Loading

  • Fix linter in CI
  • Set PyTorch version to 2.1.0 for now as xformers does not yet support 2.1.1

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2023
@JadeCopet JadeCopet changed the title Fix linter in CI Fix linter in CI + set PyTorch version Nov 21, 2023
@JadeCopet JadeCopet merged commit aaead2d into main Nov 21, 2023
3 checks passed
@JadeCopet JadeCopet deleted the fix_linter branch November 21, 2023 17:24
J4BEZ added a commit to J4BEZ/audiocraft that referenced this pull request Dec 15, 2023
@J4BEZ
Edit installation (PyTorch 2.0.0 -> 2.1.0)
f24f3de 
`requiremetns.txt`[facebookresearch#352] and the code shell in the installation guide[facebookresearch#367] teach us audiocraft requires PyTorch 2.1.0,

so I modified the guide a little (2.0.0 -> 2.1.0)

Thank you for your hard work and dedication for sharing and developing interesting project.🙇‍♂️🙇‍♂️

Hope you stay healty and have a Happy Christmas season
@J4BEZ J4BEZ mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JadeCopet @facebook-github-bot