Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compression_model from lm checkpoints #368

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

adefossez
Copy link
Contributor

The compression_model is stored inside the checkpoint, but not reliably used in different parts of the code. For consistency, it should always be loaded from the origina compression_model_checkpoint and thus is not needed in the checkpoint file.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2023
Copy link
Contributor

@JadeCopet JadeCopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Alex!

@JadeCopet JadeCopet merged commit 8aa48dd into facebookresearch:main Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants