Magnet xformers 0.0.22 compatibility fix #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2024 10:51
…plementation, which seems to yield a better audio quality.
facebook-github-bot
added
the
CLA Signed
|
Can confirm this resolves #390 :) thanks!! |
Closed
|
Validated also that training functions correctly. Generation results after 25 epochs sound totally sane. Ready for merge. |
Dinglet
pushed a commit
to Dinglet/audiocraft
that referenced
this pull request
Jul 30, 2024
MAGNeT - Fix for xformers 0.0.22 compatibility, thanks to @nateraw catch. In addition, the following smaller fixes are also contained in this PR: * MAGNeT notebook - change to stride1 span arrangement by default. * MAGNeT doc fix of a typo. * MAGNeT music training grid typo fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAGNeT - Fix for xformers 0.0.22 compatibility, thanks to @nateraw catch.
In addition, the following smaller fixes are also contained in this PR: