Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name 'unfold1d' in dynamicconv_layer.py #1029

Closed
cclauss opened this issue Aug 17, 2019 · 1 comment
Closed

Undefined name 'unfold1d' in dynamicconv_layer.py #1029

cclauss opened this issue Aug 17, 2019 · 1 comment

Comments

@cclauss
Copy link
Contributor

cclauss commented Aug 17, 2019

flake8 testing of https://github.com/pytorch/fairseq on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./fairseq/modules/dynamicconv_layer/dynamicconv_layer.py:146:24: F821 undefined name 'unfold1d'
            x_unfold = unfold1d(x, K, padding_l, 0)
                       ^
1     F821 undefined name 'unfold1d'
1
@myleott
Copy link
Contributor

myleott commented Aug 19, 2019

Fixed in 6ce55e4

@myleott myleott closed this as completed Aug 19, 2019
facebook-github-bot pushed a commit that referenced this issue Mar 1, 2020
Summary:
sanitized vq-wav2vec implementation. i will also add docs to this. i have a fixed-up checkpoint that this code can load and verified that it produces same results as what we used in paper
Pull Request resolved: fairinternal/fairseq-py#1029

Differential Revision: D20129246

Pulled By: alexeib

fbshipit-source-id: f72f455e0c309168e644ab86ec18c768c308da98
louismartin pushed a commit to louismartin/fairseq that referenced this issue Mar 24, 2020
Summary:
sanitized vq-wav2vec implementation. i will also add docs to this. i have a fixed-up checkpoint that this code can load and verified that it produces same results as what we used in paper
Pull Request resolved: fairinternal/fairseq-py#1029

Differential Revision: D20129246

Pulled By: alexeib

fbshipit-source-id: f72f455e0c309168e644ab86ec18c768c308da98
moussaKam pushed a commit to moussaKam/language-adaptive-pretraining that referenced this issue Sep 29, 2020
Summary:
sanitized vq-wav2vec implementation. i will also add docs to this. i have a fixed-up checkpoint that this code can load and verified that it produces same results as what we used in paper
Pull Request resolved: fairinternal/fairseq-py#1029

Differential Revision: D20129246

Pulled By: alexeib

fbshipit-source-id: f72f455e0c309168e644ab86ec18c768c308da98
yfyeung pushed a commit to yfyeung/fairseq that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants