Dockerfile for fastText #3
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
|
Good stuff, working in container instead of machine makes a lot of sense. Does this image include all required python tools as well? |
| @@ -28,6 +28,18 @@ $ make | |||
| This will produce object files for all the classes as well as the main binary `fasttext`. | |||
| If you do not plan on using the default system-wide compiler, update the two macros defined at the beginning of the Makefile (CC and INCLUDES). | |||
|
|
|||
| ## Docker Build of fastText | |||
|
|
|||
| In order to build `fastText` with DOcker, use the following: | |||
|
@alexbeletsky The current |
|
Hi, We find the idea of writing a docker file very interesting! However, since it is not core to the library, could you put it in another repository that we mention in the readme? Best Regards Piotr |
|
Separate repository for the Dockerfile created! Apologies for the delay & reopen. Not sure where in the README.md you'd prefer to have the link, so I put it near the Building header. The example Docker repository includes:
Happy to include anything else others find value. |
| @@ -29,6 +29,10 @@ $ make | |||
| This will produce object files for all the classes as well as the main binary `fasttext`. | |||
| If you do not plan on using the default system-wide compiler, update the two macros defined at the beginning of the Makefile (CC and INCLUDES). | |||
|
|
|||
| ### Building with Docker | |||
|
|
|||
| To build with Docker, see [fastText-Docker](https://github.com/xeb/fastText-docker) repository. | |||
There was a problem hiding this comment.
I would rather be less directive and simply advertise that a docker build file is available at.
Something like: "If you want to build with docker, please check ...".
Thanks!
|
I pulled your readme and corrected the wording. Thanks! |
* Rename -hashOnly to -mode floret In parallel to `spacy init vectors --mode floret`, rename the boolean option `-hashOnly` to `-mode floret` with the default `-mode fasttext`. * Set version to v0.10.0.dev1
I thought I'd share the Dockerfile I've been using during training and hopefully serving one day soon. I'd suggest publishing in DockerHub.